git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] read-cache: fix file time comparisons with different precisions

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Sep 29, 2015, 13:42 UTC
Message-ID
<acb5b10221675dd6cc6b9f3846cbe8c4@dscho.org>
In-Reply-To
<560A66A9.2010606@gmail.com>
Hi Karsten,
On 2015-09-29 12:23, Karsten Blees wrote:
Show 5 quoted lines
> Am 28.09.2015 um 14:52 schrieb Johannes Schindelin:
>> Otherwise there would be that little loop-hole where (nsec % 1000) == 0 *by chance* and we assume the timestamps to be identical even if they are not.
> 
> Yeah, but in this case the file would be racy, as racy-checks use
> the same comparison now.
True.
Show 6 quoted lines
> IMO change detection is so fundamental that it should Just Work,
> without having a plethora of config options that we need to explain
> to end users.
> 
> If that means that once in a million cases we need an extra content
> check to revalidate such falsely racy entries, that's fine with me.
You have a good point there. I retract my objections.

Thanks, Dscho

Previous: Karsten BleesNext: Junio C Hamano
Message 5 of 8 in “broken racy detection and performance issues with nanosecond file times”
  1. Karsten BleesSep 25, 2015
  2. read-cache: fix file time comparisons with different precisionsKarsten Blees, Sep 28, 2015
  3. Johannes SchindelinSep 28, 2015
  4. Karsten BleesSep 29, 2015
  5. Johannes SchindelinSep 29, 2015
  6. Junio C HamanoSep 28, 2015
  7. Karsten BleesSep 29, 2015
  8. Junio C HamanoSep 28, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.