From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 29 Sep 2015 13:42:39 GMT
Subject: Re: [PATCH/RFC] read-cache: fix file time comparisons with different precisions
Message-ID: <acb5b10221675dd6cc6b9f3846cbe8c4@dscho.org>
In-Reply-To: <560A66A9.2010606@gmail.com>

Hi Karsten,

On 2015-09-29 12:23, Karsten Blees wrote:
> Am 28.09.2015 um 14:52 schrieb Johannes Schindelin:
>> Otherwise there would be that little loop-hole where (nsec % 1000) == 0 *by chance* and we assume the timestamps to be identical even if they are not.
> 
> Yeah, but in this case the file would be racy, as racy-checks use
> the same comparison now.

True.

> IMO change detection is so fundamental that it should Just Work,
> without having a plethora of config options that we need to explain
> to end users.
> 
> If that means that once in a million cases we need an extra content
> check to revalidate such falsely racy entries, that's fine with me.

You have a good point there. I retract my objections.

Thanks,
Dscho