git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 01/11] test-lib: catch misspelt 'test_expect_successo'

From
Patrick Steinhardt <ps@pks.im>
Date
Mar 27, 2026, 07:53 UTC
Message-ID
<acY3haGPHPLSfalj@pks.im>
In-Reply-To
<20260326172920.GA2447148@coredump.intra.peff.net>
On Thu, Mar 26, 2026 at 01:29:20PM -0400, Jeff King wrote:
Show 28 quoted lines
> On Thu, Mar 26, 2026 at 07:27:44AM -0700, Junio C Hamano wrote:
> 
> > >  test_expect_success !MINGW 'a constipated git dies with SIGPIPE' '
> > > -	OUT=$( ((large_git; echo $? 1>&3) | :) 3>&1 ) &&
> > > +	OUT=$( ((large_git || echo $? 1>&3) | :) 3>&1 ) &&
> > >  	test_match_signal 13 "$OUT"
> > >  '
> > >  
> > >
> > > That neglects to echo $? when large_git surprisingly succeeds, but that
> > > would mean $OUT is empty, which would cause the test to (correctly)
> > > fail. I kind of hate it, though.
> > 
> > Would
> > 
> > 	OUT=$( ((large_git && echo 0 || echo $? 1>&3) | :) 3>&1 )
> > 
> > do a bit better?
> 
> Yeah, that is better (though in practice the same for our purposes in
> this particular test).
> 
> > We can keep fixing things one by one as we find these little
> > glitches and gochas, of it may be a whack-a-mole exercise that
> > eventually will turn out to be futile.  I dunno.
> 
> Yeah, after getting the tests passing locally I pushed to CI and saw a
> ton of failures. I think one is just:

I think the exercise is still worth it -t most of the changes are trivial, and it does help to make our tests a bit more robust.

Let me know in case you get worn out by this though and then I'm happy to take over. I like to have a numb task every now and then where I don't have to think much, and this here very much is such a task :)

Patrick
Previous: Jeff KingNext: Junio C Hamano
Message 6 of 28 in “detect misspelt test_expect_success and friends”
  1. 00/11 detect misspelt test_expect_success and friendsJunio C Hamano, Mar 25, 2026
  2. 01/11 test-lib: catch misspelt 'test_expect_successo'Junio C Hamano, Mar 25, 2026
  3. Jeff KingMar 26, 2026
  4. Junio C HamanoMar 26, 2026
  5. Jeff KingMar 26, 2026
  6. Patrick SteinhardtMar 27, 2026
  7. Junio C HamanoMar 27, 2026
  8. Patrick SteinhardtMar 31, 2026
  9. 02/11 t0008: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  10. 03/11 t6002: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  11. Patrick SteinhardtMar 25, 2026
  12. Junio C HamanoMar 25, 2026
  13. 04/11 t4032: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  14. Patrick SteinhardtMar 25, 2026
  15. 05/11 t7450: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  16. Patrick SteinhardtMar 25, 2026
  17. 06/11 tests: make svn test "set -e" cleanJunio C Hamano, Mar 25, 2026
  18. Patrick SteinhardtMar 25, 2026
  19. 07/11 t7508: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  20. 08/11 t9200: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  21. Patrick SteinhardtMar 25, 2026
  22. 09/11 t940?: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  23. 10/11 t5570: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  24. Patrick SteinhardtMar 25, 2026
  25. Junio C HamanoMar 25, 2026
  26. 11/11 t9902: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  27. Patrick SteinhardtMar 25, 2026
  28. Junio C HamanoMar 25, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.