git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/11] detect misspelt test_expect_success and friends

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 25, 2026, 13:47 UTC
Message-ID
<87bjgcja13.fsf@gitster.g>
In-Reply-To
<acOJ7EHFF11LJRKS@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 19 quoted lines
>> Note that I let cvs, svn, and p4 tests run only up to the point that
>> they decide to punt due to lack of external tools and language
>> bindings they require, so for those of you who do have the necessary
>> bindings, the scripts may still fail due to construct that are not
>> "set -e" clean after they call "test_done" for me.
>> 
>>  01/11: test-lib: catch misspelt 'test_expect_successo'
>>  02/11: t0008: make test "set -e" clean
>>  03/11: t6002: make test "set -e" clean
>>  04/11: t4032: make test "set -e" clean
>>  05/11: t7450: make test "set -e" clean
>>  06/11: tests: make svn test "set -e" clean
>>  07/11: t7508: make test "set -e" clean
>>  08/11: t9200: make test "set -e" clean
>>  09/11: t940?: make test "set -e" clean
>>  10/11: t5570: make test "set -e" clean
>>  11/11: t9902: make test "set -e" clean
>
> Oh well, you beat me to it :)

I may have posted these before you did, but from what you see on your comments to these patches, it seems that you did a better job, perhaps? I focused on staying as close to the original implemenation as possible to reduce the chances of silly mistakes that subtly change the semantics, but for some obvious cases, trivial improvements like turning "! A || B" into "if A; then B; fi" may be worthwhile clean-up to be done in the same series (if not in the same patch).

Thanks.
Previous: Patrick Steinhardt
Message 28 of 28 in “detect misspelt test_expect_success and friends”
  1. 00/11 detect misspelt test_expect_success and friendsJunio C Hamano, Mar 25, 2026
  2. 01/11 test-lib: catch misspelt 'test_expect_successo'Junio C Hamano, Mar 25, 2026
  3. Jeff KingMar 26, 2026
  4. Junio C HamanoMar 26, 2026
  5. Jeff KingMar 26, 2026
  6. Patrick SteinhardtMar 27, 2026
  7. Junio C HamanoMar 27, 2026
  8. Patrick SteinhardtMar 31, 2026
  9. 02/11 t0008: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  10. 03/11 t6002: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  11. Patrick SteinhardtMar 25, 2026
  12. Junio C HamanoMar 25, 2026
  13. 04/11 t4032: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  14. Patrick SteinhardtMar 25, 2026
  15. 05/11 t7450: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  16. Patrick SteinhardtMar 25, 2026
  17. 06/11 tests: make svn test "set -e" cleanJunio C Hamano, Mar 25, 2026
  18. Patrick SteinhardtMar 25, 2026
  19. 07/11 t7508: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  20. 08/11 t9200: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  21. Patrick SteinhardtMar 25, 2026
  22. 09/11 t940?: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  23. 10/11 t5570: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  24. Patrick SteinhardtMar 25, 2026
  25. Junio C HamanoMar 25, 2026
  26. 11/11 t9902: make test "set -e" cleanJunio C Hamano, Mar 25, 2026
  27. Patrick SteinhardtMar 25, 2026
  28. Junio C HamanoMar 25, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.