Re: [PATCH 4/5] refs/reftable-backend: drop uses of the_repository

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 27, 2026, 07:50 UTC
Message-ID: <acY2suRJ4OlNHYu7@pks.im>
In-Reply-To: <20260325164833.1216577-5-shreyanshpaliwalcmsmn@gmail.com>

On Wed, Mar 25, 2026 at 10:14:21PM +0530, Shreyansh Paliwal wrote:

Show 9 quoted lines

> reftable_be_init() and reftable_be_create_on_disk() use the_repository even
> though a repository instance is already available, either directly or via
> struct ref_store.
> 
> Replace these uses with the appropriate local repository instance (repo or
> ref_store->repo) to avoid relying on global state.
> 
> Note that USE_THE_REPOSITORY_VARIABLE cannot be removed yet, as
> is_bare_repository() is still there in the file.

Yeah, `is_bare_repository()` is a blocker in many files :(

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.