Re: [PATCH v2 0/8] some diff-highlight tweaks
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Mar 24, 2026, 06:50 UTC
- Message-ID
- <acI0PcVF2wbjvGva@pks.im>
- In-Reply-To
- <xmqqfr5q5wm7.fsf@gitster.g>
On Mon, Mar 23, 2026 at 09:38:56AM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> Jeff King <peff@peff.net> writes: > > > Here's a re-roll based on the review from Yuchen. The two changes are: > > > > 1. Added a missing &&-chain in patch 3 (which cascades into patch 6). > > > > 2. Avoid length(undef), since old perl versions will warn about it. > > > > Patch list and range diff below. > > Everything looks as expected from watching the discussion from > the sideline. Looking good. > > Will queue and mark the topic for 'next'.
I just read through the series and couldn't find anything wrong. That being said, my Perl skills are severely lacking, so my assessment may not be worth much :)
Thanks!
Patrick