[PATCH 3/8] diff-highlight: check diff-highlight exit status in tests
- From
Jeff King <peff@peff.net>
- Date
- Mar 20, 2026, 00:43 UTC
- Message-ID
- <20260320004303.GC3654226@coredump.intra.peff.net>
- In-Reply-To
- <20260320004138.GA3653623@coredump.intra.peff.net>
When testing diff-highlight, we pipe the output through a sanitizing function. This loses the exit status of diff-highlight itself, which could mean we are missing cases where it crashes or exits unexpectedly. Use an extra tempfile to avoid the pipe.
Signed-off-by: Jeff King <peff@peff.net> --- contrib/diff-highlight/t/t9400-diff-highlight.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/contrib/diff-highlight/t/t9400-diff-highlight.sh b/contrib/diff-highlight/t/t9400-diff-highlight.sh index 2a9b68cf3b..42d331c6cd 100755 --- a/contrib/diff-highlight/t/t9400-diff-highlight.sh +++ b/contrib/diff-highlight/t/t9400-diff-highlight.sh @@ -41,8 +41,10 @@ dh_test () { git show >commit.raw } >/dev/null && - "$DIFF_HIGHLIGHT" <diff.raw | test_strip_patch_header >diff.act && - "$DIFF_HIGHLIGHT" <commit.raw | test_strip_patch_header >commit.act && + "$DIFF_HIGHLIGHT" <diff.raw >diff.hi && + test_strip_patch_header <diff.hi >diff.act + "$DIFF_HIGHLIGHT" <commit.raw >commit.hi && + test_strip_patch_header <commit.hi >commit.act && test_cmp patch.exp diff.act && test_cmp patch.exp commit.act }
-- 2.53.0.945.ge67b727e8d