Re: [PATCH v6 3/3] rev-list: support --no-filter argument
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Dec 13, 2017, 18:38 UTC
- Message-ID
- <ac918329-82bb-1d71-ae44-df16878b4934@jeffhostetler.com>
- In-Reply-To
- <CAP8UFD1A8+tRqeY5v9gbbUHY6W6fS2LS-7Z3zCqiBZQ8ZTHkNg@mail.gmail.com>
On 12/11/2017 1:17 AM, Christian Couder wrote:
Show 27 quoted lines
> On Tue, Dec 5, 2017 at 5:50 PM, Jeff Hostetler <git@jeffhostetler.com> wrote: >> From: Jeff Hostetler <jeffhost@microsoft.com> >> >> Teach rev-list to support --no-filter to override a >> previous --filter=<filter_spec> argument. This is >> to be consistent with commands that use OPT_PARSE >> macros. >> >> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com> >> --- >> Documentation/rev-list-options.txt | 15 ++++++++++----- >> builtin/rev-list.c | 4 ++++ >> 2 files changed, 14 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt >> index 11bb87f..8d8b7f4 100644 >> --- a/Documentation/rev-list-options.txt >> +++ b/Documentation/rev-list-options.txt >> @@ -715,16 +715,21 @@ ifdef::git-rev-list[] >> The form '--filter=blob:none' omits all blobs. >> + >> The form '--filter=blob:limit=<n>[kmg]' omits blobs larger than n bytes >> -or units. The value may be zero. >> +or units. n may be zero. The suffixes k, m, and g can be used to name > > "'<n>' may be zero" would be more consistent with other parts of this file. > s/k, m, and g/'k', 'm', and 'g'/ could also help.
good catch. thanks. jeff