Re: [PATCH v6 3/3] rev-list: support --no-filter argument
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Dec 11, 2017, 06:17 UTC
- Message-ID
- <CAP8UFD1A8+tRqeY5v9gbbUHY6W6fS2LS-7Z3zCqiBZQ8ZTHkNg@mail.gmail.com>
- In-Reply-To
- <20171205165014.64488-4-git@jeffhostetler.com>
On Tue, Dec 5, 2017 at 5:50 PM, Jeff Hostetler <git@jeffhostetler.com> wrote:
Show 23 quoted lines
> From: Jeff Hostetler <jeffhost@microsoft.com> > > Teach rev-list to support --no-filter to override a > previous --filter=<filter_spec> argument. This is > to be consistent with commands that use OPT_PARSE > macros. > > Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com> > --- > Documentation/rev-list-options.txt | 15 ++++++++++----- > builtin/rev-list.c | 4 ++++ > 2 files changed, 14 insertions(+), 5 deletions(-) > > diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt > index 11bb87f..8d8b7f4 100644 > --- a/Documentation/rev-list-options.txt > +++ b/Documentation/rev-list-options.txt > @@ -715,16 +715,21 @@ ifdef::git-rev-list[] > The form '--filter=blob:none' omits all blobs. > + > The form '--filter=blob:limit=<n>[kmg]' omits blobs larger than n bytes > -or units. The value may be zero. > +or units. n may be zero. The suffixes k, m, and g can be used to name
"'<n>' may be zero" would be more consistent with other parts of this file. s/k, m, and g/'k', 'm', and 'g'/ could also help.
Show 9 quoted lines
> +units in KiB, MiB, or GiB. For example, 'blob:limit=1k' is the same > +as 'blob:limit=1024'. > + > -The form '--filter=sparse:oid=<oid-ish>' uses a sparse-checkout > -specification contained in the object (or the object that the expression > -evaluates to) to omit blobs that would not be not required for a > -sparse checkout on the requested refs. > +The form '--filter=sparse:oid=<blob-ish>' uses a sparse-checkout > +specification contained in the blob (or blob-expression) '<blob-ish>'
For example here '<blob-ish>' is used.
> +to omit blobs that would not be not required for a sparse checkout on > +the requested refs.