git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-parse: have --parseopt callers exit 0 on --help

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Mar 17, 2026, 11:59 UTC
Message-ID
<ablCBkmOdoourCnO@fruit.crustytoothpaste.net>
In-Reply-To
<xmqqcy13mgdk.fsf@gitster.g>
On 2026-03-17 at 00:47:19, Junio C Hamano wrote:
Show 22 quoted lines
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
> 
> > Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> > ---
> >  parse-options.c               | 2 +-
> >  t/t1502-rev-parse-parseopt.sh | 9 +++++++--
> >  t/t1502/optionspec-neg.help   | 1 +
> >  t/t1502/optionspec.help       | 1 +
> >  4 files changed, 10 insertions(+), 3 deletions(-)
> 
> Has t1517 passed for you?
> 
> Queued directly on top of v2.53.0, I am seeing:
> 
> >>>>>
> expecting success of 1517.169 ''git instaweb -h' outside a repository':
>                 test_expect_code 129 nongit git $cmd -h >usage &&
>                 test_grep "[Uu]sage: git $cmd " usage
> 
> test_expect_code: command exited with 0, we wanted 129 nongit git instaweb -h
> not ok 169 - 'git instaweb -h' outside a repository
> <<<<<

I thought the tests passed, but I may have neglected to run them on the latest revision. Go ahead and drop this for now and I'll send out a v2 either tonight or later this week. My apologies.

-- 
brian m. carlson (they/them)
Toronto, Ontario, CA
Previous: Junio C HamanoNext: Jeff King
Message 7 of 39 in “Unexpected exit code for --help with rev-parse --parseopt”
  1. brian m. carlsonMar 15, 2026
  2. Jeff KingMar 15, 2026
  3. brian m. carlsonMar 15, 2026
  4. Jeff KingMar 15, 2026
  5. rev-parse: have --parseopt callers exit 0 on --helpbrian m. carlson, Mar 16, 2026
  6. Junio C HamanoMar 17, 2026
  7. brian m. carlsonMar 17, 2026
  8. Jeff KingMar 17, 2026
  9. Jeff KingMar 17, 2026
  10. Junio C HamanoMar 17, 2026
  11. Jeff KingMar 17, 2026
  12. brian m. carlsonMar 18, 2026
  13. Jeff KingMar 18, 2026
  14. Junio C HamanoMar 18, 2026
  15. 0/4 rev-parse: exit 0 on --helpbrian m. carlson, Jul 1, 2026
  16. 3/4 rev-parse: have --parseopt callers exit 0 on --helpbrian m. carlson, Jul 1, 2026
  17. Junio C HamanoJul 1, 2026
  18. 1/4 t1517: skip svn tests if svn is not installedbrian m. carlson, Jul 1, 2026
  19. Junio C HamanoJul 1, 2026
  20. Junio C HamanoJul 1, 2026
  21. brian m. carlsonJul 2, 2026
  22. Jeff KingJul 2, 2026
  23. Junio C HamanoJul 3, 2026
  24. Jeff KingJul 4, 2026
  25. 4/4 parse-options: exit 0 on -hbrian m. carlson, Jul 1, 2026
  26. 2/4 parse-options: add a separate case for help output on errorbrian m. carlson, Jul 1, 2026
  27. Jeff KingJul 2, 2026
  28. Junio C HamanoJul 1, 2026
  29. Jeff KingJul 2, 2026
  30. Junio C HamanoJul 3, 2026
  31. 0/4 parseopt: exit 0 on helpbrian m. carlson, Jul 8, 2026
  32. 1/4 t1517: skip svn tests if svn is not installedbrian m. carlson, Jul 8, 2026
  33. Junio C HamanoJul 8, 2026
  34. 3/4 rev-parse: have --parseopt callers exit 0 on --helpbrian m. carlson, Jul 8, 2026
  35. 2/4 parse-options: add a separate case for help output on errorbrian m. carlson, Jul 8, 2026
  36. Junio C HamanoJul 8, 2026
  37. 4/4 parse-options: exit 0 on -hbrian m. carlson, Jul 8, 2026
  38. Jeff KingJul 8, 2026
  39. Junio C HamanoJul 8, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.