git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/4] rev-parse: exit 0 on --help

From
Jeff King <peff@peff.net>
Date
Jul 2, 2026, 08:45 UTC
Message-ID
<20260702084519.GB481298@coredump.intra.peff.net>
In-Reply-To
<xmqqcxx6mkjn.fsf@gitster.g>
On Wed, Jul 01, 2026 at 03:06:52PM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> > One of the patches is rather long because we have many cases in which
> > we've hard-coded exit code 129 into our tests.  However, the changes
> > there should not be complex, only somewhat tedious to review.
> 
> It is borderline for "yes, we all know it is obvious that things
> should have worked this way from day one, we regret that it is not
> the case, but it has been working differently and users' scripts all
> have been working with the current behaviour, and it is likely that
> they will all break".
> 
> Two big things that make it much less likely, saving grace, are that
> this is only about "--help" (which is unlikely to be a part of
> end-user script), and this makes the invocation succeed (if we were
> changing from exit 0 to exit 129, we would be breaking tons more).

My big concern is a script accidentally continuing when fed "--help" and generating nonsense. But I think the eval magic explained in patch 3 makes that unlikely (any such caller was already kind-of broken).

The other issue I raised in the earlier round is that a script like:
  cat >git-foo <<\EOF
  #!/bin/sh
  git log --my-options "$@" >output || exit 1
  do_something <output
  EOF

when invoked as "git foo --help" will now call do_something with nonsense input, rather than exiting from the "error" returned by git-log. This only affects hacky little scripts like this that are not otherwise parsing their own options, but sometimes those are the most common. ;)

I'm not convinced there will be much fallout, but it is possible.
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 29 of 39 in “Unexpected exit code for --help with rev-parse --parseopt”
  1. brian m. carlsonMar 15, 2026
  2. Jeff KingMar 15, 2026
  3. brian m. carlsonMar 15, 2026
  4. Jeff KingMar 15, 2026
  5. rev-parse: have --parseopt callers exit 0 on --helpbrian m. carlson, Mar 16, 2026
  6. Junio C HamanoMar 17, 2026
  7. brian m. carlsonMar 17, 2026
  8. Jeff KingMar 17, 2026
  9. Jeff KingMar 17, 2026
  10. Junio C HamanoMar 17, 2026
  11. Jeff KingMar 17, 2026
  12. brian m. carlsonMar 18, 2026
  13. Jeff KingMar 18, 2026
  14. Junio C HamanoMar 18, 2026
  15. 0/4 rev-parse: exit 0 on --helpbrian m. carlson, Jul 1, 2026
  16. 3/4 rev-parse: have --parseopt callers exit 0 on --helpbrian m. carlson, Jul 1, 2026
  17. Junio C HamanoJul 1, 2026
  18. 1/4 t1517: skip svn tests if svn is not installedbrian m. carlson, Jul 1, 2026
  19. Junio C HamanoJul 1, 2026
  20. Junio C HamanoJul 1, 2026
  21. brian m. carlsonJul 2, 2026
  22. Jeff KingJul 2, 2026
  23. Junio C HamanoJul 3, 2026
  24. Jeff KingJul 4, 2026
  25. 4/4 parse-options: exit 0 on -hbrian m. carlson, Jul 1, 2026
  26. 2/4 parse-options: add a separate case for help output on errorbrian m. carlson, Jul 1, 2026
  27. Jeff KingJul 2, 2026
  28. Junio C HamanoJul 1, 2026
  29. Jeff KingJul 2, 2026
  30. Junio C HamanoJul 3, 2026
  31. 0/4 parseopt: exit 0 on helpbrian m. carlson, Jul 8, 2026
  32. 1/4 t1517: skip svn tests if svn is not installedbrian m. carlson, Jul 8, 2026
  33. Junio C HamanoJul 8, 2026
  34. 3/4 rev-parse: have --parseopt callers exit 0 on --helpbrian m. carlson, Jul 8, 2026
  35. 2/4 parse-options: add a separate case for help output on errorbrian m. carlson, Jul 8, 2026
  36. Junio C HamanoJul 8, 2026
  37. 4/4 parse-options: exit 0 on -hbrian m. carlson, Jul 8, 2026
  38. Jeff KingJul 8, 2026
  39. Junio C HamanoJul 8, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.