Re: [PATCH 2/2] xdiff: optimize xdl_hash_record_verbatim

From: Alexander Monakov <amonakov@ispras.ru>
Date: Sep 8, 2025, 19:06 UTC
Message-ID: <abb2bc1a-e68b-85a3-2562-53328fb502c6@ispras.ru>
In-Reply-To: <xmqq7byx8yo3.fsf@gitster.g>

On Wed, 20 Aug 2025, Junio C Hamano wrote:

Show 5 quoted lines

> The thread has gone quiet.  I assume everybody is happy with the
> result?  Can we have a hopefully final v2 iteration of these
> patches, to address the updated to the table (this thread), to
> squelch the __asm__() issue [*asm*], and a reword you mentioned
> [*reword*] against Phillip's review?

I was expecting that Phillip would come back to the question of underwhelming performance improvement he was seeing on his CPU. I was working on an alternative approach to speed up that function, which I just sent in the v2 thread: https://lore.kernel.org/git/20250908184939.16338-4-amonakov@ispras.ru/ It does not depend on the performance of integer multiplication anymore, so it should work better from architecture neutrality point of view.

I'm not sure what's the current status though, it seems nobody gave the original two patches a Reviewed-by?

If the proposed changes in v2 are too sudden, what happens now?

Thanks. Alexander