git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] history: initialize rev_info in cmd_history_reword()

From
Patrick Steinhardt <ps@pks.im>
Date
Mar 10, 2026, 12:16 UTC
Message-ID
<abALiEDdNXCTzVux@pks.im>
In-Reply-To
<b0b8633f-be95-48eb-8244-d0e3f1a7be72@web.de>
On Sun, Mar 08, 2026 at 10:57:02AM +0100, René Scharfe wrote:
Show 5 quoted lines
> git history reword expects a single valid revision argument and errors
> out if it doesn't get it.  In that case the struct rev_info passed to
> release_revisions() for cleanup is still uninitialized, which can result
> in attempts to free(3) random pointers.  Avoid that by initializing the
> structure.
This looks obviously correct to me. Thanks!
Patrick
Previous: René Scharfe
Message 2 of 2 in “history: initialize rev_info in cmd_history_reword()”
  1. history: initialize rev_info in cmd_history_reword()René Scharfe, Mar 8, 2026
  2. Patrick SteinhardtMar 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.