From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 10 Mar 2026 12:16:08 GMT
Subject: Re: [PATCH] history: initialize rev_info in cmd_history_reword()
Message-ID: <abALiEDdNXCTzVux@pks.im>
In-Reply-To: <b0b8633f-be95-48eb-8244-d0e3f1a7be72@web.de>

On Sun, Mar 08, 2026 at 10:57:02AM +0100, René Scharfe wrote:
> git history reword expects a single valid revision argument and errors
> out if it doesn't get it.  In that case the struct rev_info passed to
> release_revisions() for cleanup is still uninitialized, which can result
> in attempts to free(3) random pointers.  Avoid that by initializing the
> structure.

This looks obviously correct to me. Thanks!

Patrick