Re: [PATCH v2] promisor-remote: add promisor.quiet configuration option
On 24/05/2024 19:06, Junio C Hamano wrote:
Show 15 quoted lines
> Wouldn't we want to see this as three (or four) tests,
>
> (1) "setup" that prepares the server end
>
> (2) "quiet=false" test that
> - makes a partial clone,
> - sets .quiet to false,
> - runs cat-file -p,
> - makes sure that the lazy fetching is chatty.
>
> (3) "quiet=true" test, which is the same as (2) except that it sets
> .quiet to true and expects the lazy fetching to be silent.
>
> (4) "quiet=unconfigured" test, which is the same as (2) except that
> it leaves .quiet unconfigured.
Sounds good to me. I've sent a v3 with those changes.
Tom
--
Tom Hughes (tom@compton.nu)
http://compton.nu/