From: Tom Hughes <tom@compton.nu>
Date: Sat, 25 May 2024 10:10:24 GMT
Subject: Re: [PATCH v2] promisor-remote: add promisor.quiet configuration option
Message-ID: <ab69eeda-65d2-4e38-9abc-fb1230fe8ab6@compton.nu>
In-Reply-To: <xmqqa5kfkrsu.fsf@gitster.g>

On 24/05/2024 19:06, Junio C Hamano wrote:

> Wouldn't we want to see this as three (or four) tests,
> 
>   (1) "setup" that prepares the server end
> 
>   (2) "quiet=false" test that
>       - makes a partial clone,
>       - sets .quiet to false,
>       - runs cat-file -p,
>       - makes sure that the lazy fetching is chatty.
> 
>   (3) "quiet=true" test, which is the same as (2) except that it sets
>       .quiet to true and expects the lazy fetching to be silent.
> 
>   (4) "quiet=unconfigured" test, which is the same as (2) except that
>       it leaves .quiet unconfigured.

Sounds good to me. I've sent a v3 with those changes.

Tom

-- 
Tom Hughes (tom@compton.nu)
http://compton.nu/