git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 18:04 UTC

Re: [PATCH 1/2] t7412: fix typo 'submodue' in test_description

From
Patrick Steinhardt <ps@pks.im>
Date
Mar 4, 2026, 05:16 UTC
Message-ID
<aafAIqqq1PdzmQW3@pks.im>
In-Reply-To
<20260303175750.361563-1-ysinghcin@gmail.com>
On Tue, Mar 03, 2026 at 11:27:49PM +0530, Yuvraj Singh Chauhan wrote:

One micro nit, not worth rerolling over: I think in general we prefer to have at least a sentence in the commit message body, even if it repeats most of what the subject has already said.

At least for me it makes the review a bit easier, as the subject of the message will be gone at the time I start writing a reply during the review.

Show 17 quoted lines
> Signed-off-by: Yuvraj Singh Chauhan <ysinghcin@gmail.com>
> ---
>  t/t7412-submodule-absorbgitdirs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/t/t7412-submodule-absorbgitdirs.sh b/t/t7412-submodule-absorbgitdirs.sh
> index 0490499573..41ee035e3c 100755
> --- a/t/t7412-submodule-absorbgitdirs.sh
> +++ b/t/t7412-submodule-absorbgitdirs.sh
> @@ -2,7 +2,7 @@
>  
>  test_description='Test submodule absorbgitdirs
>  
> -This test verifies that `git submodue absorbgitdirs` moves a submodules git
> +This test verifies that `git submodule absorbgitdirs` moves a submodules git
>  directory into the superproject.
>  '
An obvious fix indeed.
Patrick
Previous: Yuvraj Singh ChauhanNext: Patrick Steinhardt
Message 3 of 4 in “t7412: fix typo 'submodue' in test_description”
  1. 1/2 t7412: fix typo 'submodue' in test_descriptionYuvraj Singh Chauhan, Mar 3, 2026
  2. 2/2 t7412: modernize path checks to use test helper functionsYuvraj Singh Chauhan, Mar 3, 2026
  3. Patrick SteinhardtMar 4, 2026
  4. Patrick SteinhardtMar 4, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.