From: Patrick Steinhardt Date: Wed, 04 Mar 2026 05:16:18 GMT Subject: Re: [PATCH 1/2] t7412: fix typo 'submodue' in test_description Message-ID: In-Reply-To: <20260303175750.361563-1-ysinghcin@gmail.com> On Tue, Mar 03, 2026 at 11:27:49PM +0530, Yuvraj Singh Chauhan wrote: One micro nit, not worth rerolling over: I think in general we prefer to have at least a sentence in the commit message body, even if it repeats most of what the subject has already said. At least for me it makes the review a bit easier, as the subject of the message will be gone at the time I start writing a reply during the review. > Signed-off-by: Yuvraj Singh Chauhan > --- > t/t7412-submodule-absorbgitdirs.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t7412-submodule-absorbgitdirs.sh b/t/t7412-submodule-absorbgitdirs.sh > index 0490499573..41ee035e3c 100755 > --- a/t/t7412-submodule-absorbgitdirs.sh > +++ b/t/t7412-submodule-absorbgitdirs.sh > @@ -2,7 +2,7 @@ > > test_description='Test submodule absorbgitdirs > > -This test verifies that `git submodue absorbgitdirs` moves a submodules git > +This test verifies that `git submodule absorbgitdirs` moves a submodules git > directory into the superproject. > ' An obvious fix indeed. Patrick