Re: [PATCH] show-index: warn when falling back to SHA-1 outside a repository
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Jan 29, 2026, 23:12 UTC
- Message-ID
- <aXvpSPpfvulKu57P@fruit.crustytoothpaste.net>
- In-Reply-To
- <20260129153948.224156-1-shreyanshpaliwalcmsmn@gmail.com>
On 2026-01-29 at 15:36:55, Shreyansh Paliwal wrote:
Show 13 quoted lines
> /*
> * Fallback to SHA1 if we are running outside of a repository.
> *
> - * TODO: Figure out and implement a way to detect the hash algorithm in use by the
> - * the index file passed in and use that instead.
> + * TODO: If a future implementation of index file version encodes the hash
> + * algorithm in its header, enable show-index to infer it from the
> + * header rather than relying on repository context or a default fallback.
> */
> - if (!the_hash_algo)
> + if (!the_hash_algo) {
> + warning(_("assuming SHA-1; use --object-format to override"));
> repo_set_hash_algo(the_repository, GIT_HASH_DEFAULT);If we're going to start producing a warning, can we also learn a `--quiet` option to silence it?
-- brian m. carlson (they/them) Toronto, Ontario, CA