git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] show-index: implement automatic hash detection

From
Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
Date
Jan 23, 2026, 16:08 UTC
Message-ID
<20260123161017.37827-1-shreyanshpaliwalcmsmn@gmail.com>
In-Reply-To
<aXMh0pYw2ZrptCNj@pks.im>
> That would be a regression for users that currently _can_ run
> git-show-index(1) outside of a repository with a SHA-1 based index. It's
> not going to be a common use case, but I wouldn't be surprised if there
> was at least one user out there that we'd break with such a change.

That makes sense, but relying on a silent SHA-1 fallback purely because we are outside of a repository still feels a bit ambiguous to me. It works today mostly because SHA-1 has historically been the default, but if in future git introduces additional hash functions or if SHA-256 indexes become more relevant to this particular usage.

Though, I think based on the discussion so far, we can only show a warning like this along with the SHA-1 fallback like this,

    warning(_("assuming SHA-1; use --object-format to override"));

Do you think if this would be appropriate, or if anything better can be done to handle this or is it just better to leave the behavior as-is. Let me know :)

Best, Shreyansh

Previous: Patrick SteinhardtNext: brian m. carlson
Message 7 of 25 in “show-index: modernize and implement auto-detection of hash algorithm”
  1. Shreyansh PaliwalJan 20, 2026
  2. 1/3 show-index: implement automatic hash detectionShreyansh Paliwal, Jan 20, 2026
  3. Junio C HamanoJan 20, 2026
  4. Patrick SteinhardtJan 21, 2026
  5. Shreyansh PaliwalJan 21, 2026
  6. Patrick SteinhardtJan 23, 2026
  7. Shreyansh PaliwalJan 23, 2026
  8. brian m. carlsonJan 23, 2026
  9. Shreyansh PaliwalJan 21, 2026
  10. 2/3 show-index: use gettext wrapping in error messagesShreyansh Paliwal, Jan 20, 2026
  11. 3/3 show-index: remove global state variablesShreyansh Paliwal, Jan 20, 2026
  12. Phillip WoodJan 21, 2026
  13. Shreyansh PaliwalJan 21, 2026
  14. Junio C HamanoJan 21, 2026
  15. show-index: warn when falling back to SHA-1 outside a repositoryShreyansh Paliwal, Jan 29, 2026
  16. Junio C HamanoJan 29, 2026
  17. Shreyansh PaliwalJan 30, 2026
  18. brian m. carlsonJan 29, 2026
  19. Shreyansh PaliwalJan 30, 2026
  20. Patrick SteinhardtJan 30, 2026
  21. Junio C HamanoJan 30, 2026
  22. 0/2 show-index: add warning and wrap error messages with gettextShreyansh Paliwal, Jan 30, 2026
  23. 1/2 show-index: warn when falling back to SHA-1 outside a repositoryShreyansh Paliwal, Jan 30, 2026
  24. 2/2 show-index: use gettext wrapping in user facing error messagesShreyansh Paliwal, Jan 30, 2026
  25. Junio C HamanoJan 30, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.