Re: [PATCH v3 05/14] packfile: extract function to iterate through objects of a store

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 22, 2026, 01:37 UTC
Message-ID: <aXF/XfEcHA7lvyDE@nand.local>
In-Reply-To: <20260121-pks-odb-for-each-object-v3-5-12c4dfd24227@pks.im>

On Wed, Jan 21, 2026 at 01:50:21PM +0100, Patrick Steinhardt wrote:

> ---
>  packfile.c | 78 ++++++++++++++++++++++++++++++++++++--------------------------
>  1 file changed, 45 insertions(+), 33 deletions(-)

Reading with --color-moved and ignoring space changes makes it clear that this patch is extracting the logic to iterate through the packfile store of a single source into its own function, and then calling that function from within for_each_packed_object().

Seems reasonable.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.