Re: [PATCH 2/8] odb: resolve relative alternative paths when parsing
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Dec 10, 2025, 05:53 UTC
- Message-ID
- <aTkK79sZPkYQ87aS@pks.im>
- In-Reply-To
- <5lkaw3kfqzjt45jhomeb34cqu6nxigapmobtqrzpyoq7mh6655@3zgqsyfui23j>
On Tue, Dec 09, 2025 at 12:06:09PM -0600, Justin Tobler wrote:
Show 10 quoted lines
> On a semi-related note, part of me thinks it would be nice if alternate > sources were a bit more first class in `struct object_database`. IOW, > explicitly defining the primary and list of alternate sources > separately. From the perspective of reading objects, having a single > list of sources is nice, but when writing objects only the first source > is used. This isn't too big of a deal, but certain operations like ODB > trasactions will reorder the source list to change where objects get > written to which feels a bit fragile to me. I guess another way to > resolve this concern could be to change ODB transactions to use a > separate mechanism though.
Agreed, especially the writing side is a bit weird, and reordering sources when we create transactions is one of the weirdest parts. I think this is out of scope for this patch series, but I certainly think that we should address this by polishing the ODB transactions a bit going forward.
Thanks!
Patrick