Re: [PATCH 5/8] builtin/pack-objects: simplify logic to find kept or nonlocal objects

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 30, 2025, 09:52 UTC
Message-ID: <aQM1TJF97kpTygBE@pks.im>
In-Reply-To: <87wm4cu462.fsf@iotcl.com>

On Thu, Oct 30, 2025 at 10:31:17AM +0100, Toon Claes wrote:

Show 11 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > +		/*
> > +		 * We have already checked `last_found`, so there is no need to
> > +		 * re-check here.
> > +		 */
> > +		if (p == last_found && last_found != (void *)1)
> > +			continue;
> 
> Unrelated to the (void *)1 check, shouldn't this be in the beginning of
> the loop?

Oh, good catch. Yes, it of course should be, thanks!

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.