From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 30 Oct 2025 09:52:12 GMT
Subject: Re: [PATCH 5/8] builtin/pack-objects: simplify logic to find kept or nonlocal objects
Message-ID: <aQM1TJF97kpTygBE@pks.im>
In-Reply-To: <87wm4cu462.fsf@iotcl.com>

On Thu, Oct 30, 2025 at 10:31:17AM +0100, Toon Claes wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > +		/*
> > +		 * We have already checked `last_found`, so there is no need to
> > +		 * re-check here.
> > +		 */
> > +		if (p == last_found && last_found != (void *)1)
> > +			continue;
> 
> Unrelated to the (void *)1 check, shouldn't this be in the beginning of
> the loop?

Oh, good catch. Yes, it of course should be, thanks!

Patrick