git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] whitespace: correct bit assignment comments

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 29, 2025, 07:17 UTC
Message-ID
<aQG_eRPmsxKqJ0H9@pks.im>
In-Reply-To
<xmqq8qgvdm0y.fsf_-_@gitster.g>
On Tue, Oct 28, 2025 at 09:33:01AM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> A comment in diff.c claimed that bits up to 12th (counting from 0th)
> are whitespace rules, and 13th thru 15th are for new/old/context,
> but it turns out it was miscounting.  Correct them, and clarify
> where the whitespace rule bits come from in the comment.  Extend bit
> assignment comments to cover bits used for color-moved, which
> weren't described.
> 
> Also update the way these bit constants are defined to use (1 << N)
> notation, instead of octal constants, as it tends to make it easier
> to notice a breakage like this.
> 
> Sprinkle a few blank lines between logically distinct groups of CPP
> macro definitions to make them easier to read.
Thanks, this version looks good to me!
Patrick
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 6 in “whitespace: correct bit assignment comments”
  1. whitespace: correct bit assignment commentsJunio C Hamano, Oct 27, 2025
  2. Patrick SteinhardtOct 28, 2025
  3. Junio C HamanoOct 28, 2025
  4. whitespace: correct bit assignment commentsJunio C Hamano, Oct 28, 2025
  5. Patrick SteinhardtOct 29, 2025
  6. Junio C HamanoOct 29, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.