From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 29 Oct 2025 07:17:13 GMT
Subject: Re: [PATCH v2] whitespace: correct bit assignment comments
Message-ID: <aQG_eRPmsxKqJ0H9@pks.im>
In-Reply-To: <xmqq8qgvdm0y.fsf_-_@gitster.g>

On Tue, Oct 28, 2025 at 09:33:01AM -0700, Junio C Hamano wrote:
> A comment in diff.c claimed that bits up to 12th (counting from 0th)
> are whitespace rules, and 13th thru 15th are for new/old/context,
> but it turns out it was miscounting.  Correct them, and clarify
> where the whitespace rule bits come from in the comment.  Extend bit
> assignment comments to cover bits used for color-moved, which
> weren't described.
> 
> Also update the way these bit constants are defined to use (1 << N)
> notation, instead of octal constants, as it tends to make it easier
> to notice a breakage like this.
> 
> Sprinkle a few blank lines between logically distinct groups of CPP
> macro definitions to make them easier to read.

Thanks, this version looks good to me!

Patrick