Re: [PATCH v2 3/9] builtin/maintenance: introduce "geometric-repack" task
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 24, 2025, 05:45 UTC
- Message-ID
- <aPsSZ6IlbaEi9SPY@pks.im>
- In-Reply-To
- <aPqCBDLwVBKKaJU6@nand.local>
On Thu, Oct 23, 2025 at 03:29:08PM -0400, Taylor Blau wrote:
Show 20 quoted lines
> On Tue, Oct 21, 2025 at 04:13:25PM +0200, Patrick Steinhardt wrote: > > +test_expect_success 'geometric repacking task' ' > > + test_when_finished "rm -rf repo" && > > + git init repo && > > + ( > > + cd repo && > > + git config set maintenance.auto false && > > + test_commit initial && > > + > > + # The initial repack causes an all-into-one repack. > > + GIT_TRACE2_EVENT="$(pwd)/initial-repack.txt" \ > > + git maintenance run --task=geometric-repack 2>/dev/null && > > + test_subcommand git repack -d -l --cruft --cruft-expiration=2.weeks.ago --quiet --write-midx <initial-repack.txt && > > Not a show-stopper of course, but I thought from the cover letter that > these lines would have gotten wrapped. Whether or not we have lines > longer than 80 characters is not a hill that I'd like to die on, of > course ;-). But I brought it up because I am wondering if there were > some changes that you meant to include as a part of this round that got > dropped in the shuffle.
Nah, I guess I merely didn't do my due diligence to also wrap other overly long lines. Let me fix those.
Patrick