Re: [PATCH v3 03/10] builtin/maintenance: introduce "geometric-repack" task

From: Jeff King <peff@peff.net>
Date: Oct 27, 2025, 14:25 UTC
Message-ID: <20251027142503.GA2758515@coredump.intra.peff.net>
In-Reply-To: <aP8sJF45dHsVlgqt@pks.im>

On Mon, Oct 27, 2025 at 09:24:11AM +0100, Patrick Steinhardt wrote:

Show 12 quoted lines

> Interesting! I would say that this is an issue in git-repack(1) itself:
> if the geometric repack didn't lead to any new packs, and if all of the
> packs are already covered by a MIDX, then we still rather pointlessly
> regenerate the MIDX even though it won't cover anything new.
> 
> I wonder whether we want a patch like the below one? Problem though is
> that we'd also have to check whether any of the other options have
> changed, otherwise we for example wouldn't generate bitmaps.
> 
> In any case though, I feel like this is a bit out of scope for this
> patch series. Other strategies that write a MIDX behave the same, so
> this is something we can fix later on.

I agree it's out of scope for the series, but the racy test is new. So we probably at least need to make it un-racy with a comment to address the root cause later.

The patch you posted looks plausibly correct, though I agree with you that some thought needs to be given to changing options.

-Peff