Re: [PATCH v2 2/5] lib-gpg: allow tests with GPGSM or GPGSSH prereq first
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 10, 2025, 06:49 UTC
- Message-ID
- <aOisaq-rSdwjwo6b@pks.im>
- In-Reply-To
- <20251009122457.1273701-3-christian.couder@gmail.com>
On Thu, Oct 09, 2025 at 02:24:54PM +0200, Christian Couder wrote:
Show 20 quoted lines
> diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh
> index 937b876bd0..b99ae39a06 100644
> --- a/t/lib-gpg.sh
> +++ b/t/lib-gpg.sh
> @@ -9,6 +9,16 @@
> @@ -63,6 +72,14 @@ test_lazy_prereq GPG2 '
> ;;
> *)
> (gpgconf --kill all || : ) &&
> +
> + # NEEDSWORK: prepare_gnupghome() should definitely be
> + # called here, but it looks like it exposes a
> + # pre-existing, hidden bug by allowing some tests in
> + # t1016-compatObjectFormat.sh to run instead of being
> + # skipped. See:
> + # https://lore.kernel.org/git/ZoV8b2RvYxLOotSJ@teonanacatl.net/
> +
> gpg --homedir "${GNUPGHOME}" --import \
> "$TEST_DIRECTORY"/lib-gpg/keyring.gpg &&
> gpg --homedir "${GNUPGHOME}" --import-ownertrust \Interesting. So I assume that these gpg commands here fail because the GPG home doesn't exist, and thus we disable the prereq? Too bad, but I agree that this doesn't necessarily have to be fixed by this patch series.
The remaining patches look good to me and address my feedback, thanks!
Patrick