Re: [PATCH v3 0/5] fast-import: start controlling how tag signatures are handled

From: Elijah Newren <newren@gmail.com>
Date: Oct 24, 2025, 02:06 UTC
Message-ID: <CABPp-BFgKSLQazjEwCn7rFd2BiQBGri2uNxxK7EPuEOWEAf1JQ@mail.gmail.com>
In-Reply-To: <CAP8UFD0Jdb2Q5dpspUOnKBJuupikJ21mJmzRyYsNOhem-JP-9g@mail.gmail.com>

On Mon, Oct 13, 2025 at 5:10 AM Christian Couder <christian.couder@gmail.com> wrote:

Show 18 quoted lines

>
> On Mon, Oct 13, 2025 at 10:49 AM Christian Couder
> <christian.couder@gmail.com> wrote:
>
> >
> > Changes since v2
> > ----------------
> >
> > Thanks to Patrick Steinhardt, Todd Zullinger and Collin Funk who
> > reviewed or commented on the v1 and v2.
> >
> > There is a single change in the first patch (doc: git-tag: stop
> > focusing on GPG signed tags) where the description of the
> > `-v | --verify` option of `git tag` has been improved.
>
> Sorry, this should have been sent in reply to the v2
> (https://lore.kernel.org/git/20251009122457.1273701-1-christian.couder@gmail.com/)
> instead of the v1.

Sorry for the delay in reviewing; the series looks really good, with one minor exception: I'm worried about the default chosen in patch 5 (and also the default chosen for --signed-commits in the recently merged eaaddf579124 (fast-import: add '--signed-commits=<mode>' option, 2025-09-17)), as I commented on there.