Re: [PATCH 2/3] make: delete XDIFF_LIB, add xdiff to LIB_OBJS

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 2, 2025, 05:47 UTC
Message-ID: <aN4R51_j2ieF-sjy@pks.im>
In-Reply-To: <28e7fd27b632eeb681e7b9af4de2d18cd327be2a.1759341748.git.gitgitgadget@gmail.com>

On Wed, Oct 01, 2025 at 06:02:27PM +0000, Ezekiel Newren via GitGitGadget wrote:

Show 10 quoted lines

> diff --git a/Makefile b/Makefile
> index e8fad803be..d89ba03286 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1397,8 +1396,7 @@ XDIFF_OBJS += xdiff/xmerge.o
>  XDIFF_OBJS += xdiff/xpatience.o
>  XDIFF_OBJS += xdiff/xprepare.o
>  XDIFF_OBJS += xdiff/xutils.o
> -.PHONY: xdiff-objs
> -xdiff-objs: $(XDIFF_OBJS)

The removal of the `xdiff-objs` target isn't mentioned or justified in the commit message. I personally don't mind that this target goes away, as I don't really have a use case for it anyway. But in theory it could continue to exist. So I'd either retain it, or explain why it goes away.

In case it goes away, is there still a reason to have the separate XDIFF_OBJS variable? Can't we add these objects to `LIB_OBJS` directly?

Patrick