Re: [PATCH 0/3] ci: don't compile whole project when testing docs with Meson

From: Patrick Steinhardt <ps@pks.im>
Date: Sep 15, 2025, 06:04 UTC
Message-ID: <aMeshpRtFWyE0ja4@pks.im>
In-Reply-To: <xmqqwm64orc1.fsf@gitster.g>

On Thu, Sep 11, 2025 at 10:02:22AM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > these two patches introduce a new "docs" alias into Meson and use it in
> > our "documentation" CI jobs so that we stop compiling all of Git only to
> > verify the generated manpages. This fixes the issue reported by Gábor in
> > [1].
> 
> There are three patches ;-).

Oops, yeah. I added the summary patch close before sending this out :)

Show 8 quoted lines

> The end-user facing get_option() is called "docs", unlike what the
> "make" side understands, which is "make doc", even though internally
> we call the target internally as "doc_targets" (not "docs_target").
> 
> I wonder if we want to let people say "meson compile doc" to match
> the other world?
> 
> Will queue.  Thanks.

The reason why I picked 'docs' is that the accompanying user-facing option is also named the same way. It's thus a bit more consistent with itself to call the target 'docs' as well.

So I slightly lean towards keeping 'docs', but I don't feel too strongly about it.

Patrick