Re: [PATCH 3/3] ci: don't compile whole project when testing docs with Meson
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Sep 16, 2025, 09:16 UTC
- Message-ID
- <CAOLa=ZSXXk9iwnU6a9BR-jfhs0XU8MXQqa8edpOajfORV2uY5w@mail.gmail.com>
- In-Reply-To
- <20250911-b4-pks-meson-docs-target-v1-3-a92c666ecef9@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 38 quoted lines
> Our "documentation" CI jobs, unsurprisingly, performs a couple of tests > on our documentation. The job knows to not only test the documentation > generated by our Makefile, but also by Meson. > > In the latter case with Meson we end up building the whole project, > including all of the binaries. This is of course quite excessive and a > waste of compute cycles, as we don't care about these binaries at all. > > Fix this by using the new "docs" target that we introduced in the > preceding commit. > > Reported-by: SZEDER Gábor <szeder.dev@gmail.com> > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > ci/test-documentation.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ci/test-documentation.sh b/ci/test-documentation.sh > index 49f87f50fd..5e4fd8fbd7 100755 > --- a/ci/test-documentation.sh > +++ b/ci/test-documentation.sh > @@ -48,13 +48,13 @@ check_unignored_build_artifacts > > # Build docs with Meson and AsciiDoc > meson setup build-asciidoc -Ddocs=html,man -Ddocs_backend=asciidoc > -meson compile -C build-asciidoc > +meson compile -C build-asciidoc docs > check_docs build-asciidoc AsciiDoc > rm -rf build-asciidoc > > # Build docs with Meson and AsciiDoctor > meson setup build-asciidoctor -Ddocs=html,man -Ddocs_backend=asciidoctor > -meson compile -C build-asciidoctor > +meson compile -C build-asciidoctor docs > check_docs build-asciidoctor Asciidoctor > rm -rf build-asciidoctor > >
This makes sense. I really like how a lot of our CI config is forge agnostic. I opened the patch expecting to review GitHub/GitLab changes. Glad I didn't have to.
> -- > 2.51.0.450.g87641ccf93.dirty