Re: [PATCH 0/5] midx-write: fix segfault and do several cleanups

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 29, 2025, 01:36 UTC
Message-ID: <aLEENQcWvfOC7Iyn@nand.local>
In-Reply-To: <pull.1965.git.1756402795.gitgitgadget@gmail.com>

On Thu, Aug 28, 2025 at 05:39:50PM +0000, Derrick Stolee via GitGitGadget wrote:

Show 6 quoted lines

> Derrick Stolee (5):
>   midx-write: only load initialized packs
>   midx-write: put failing response value back
>   midx-write: use cleanup when incremental midx fails
>   midx-write: use uint32_t for preferred_pack_idx
>   midx-write: reenable signed comparison errors

Thanks for looking at this, and my apologies for the regression plugged by the first patch.

The last four patches look good to me, and I left just some minor comments throughout. The first patch does leave me feeling like there ought to be a smaller reproduction, but I can't seem to find one easily.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.