Re: [PATCH 5/5] midx-write: reenable signed comparison errors

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 29, 2025, 01:35 UTC
Message-ID: <aLED/YDNy9dZvkHO@nand.local>
In-Reply-To: <xmqqo6rztb2h.fsf@gitster.g>

On Thu, Aug 28, 2025 at 02:01:42PM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > The strategy here involves defining the variable within the for loop
> > syntax to make sure we use the appropriate bitness for the loop
> > sentinel. This matters in at least one method where the variable was
> > compared to uint32_t in some loops and size_t in others.
>
> Sounds like a fine way to avoid accidentally breaking these loops.

Yup, all looks good to me.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.