Re: [PATCH v2 2/2] t/unit-tests/clar: fix -Wmaybe-uninitialized with -Og

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 11, 2025, 09:00 UTC
Message-ID: <aJmxExJgFKxeiHDf@pks.im>
In-Reply-To: <aJWtbGGBOELZN6tp@generichostname>

On Fri, Aug 08, 2025 at 12:55:24AM -0700, Denton Liu wrote:

Show 16 quoted lines

> On Fri, Aug 08, 2025 at 07:48:10AM +0200, Patrick Steinhardt wrote:
> > On Mon, Aug 04, 2025 at 10:31:16PM -0700, Denton Liu wrote:
> > > When building with -Og on gcc 15.1.1, the build produces a warning. In
> > > practice, though, this cannot be hit because `exact` acts as a guard and
> > > that variable can only be set after `matchlen` is already initialized
> > > 
> > > Assign a default value to `matchlen` so that the warning is silenced.
> > 
> > Would you mind creating a PR against upstream [1] so that we also have it
> > over there? Thanks!
> 
> Good idea. PR over at [0]
> 
> -Denton
> 
> [0]: https://github.com/clar-test/clar/pull/119

Thanks, approved and merged now.

Patrick