git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/2] t/unit-tests/clar: fix -Wmaybe-uninitialized with -Og

From
Denton Liu <liu.denton@gmail.com>
Date
Aug 5, 2025, 05:31 UTC
Message-ID
<8ed0ac14092e7ec979e53d2a3da84dfe884d6b3f.1754371650.git.liu.denton@gmail.com>
In-Reply-To
<cover.1754371649.git.liu.denton@gmail.com>

When building with -Og on gcc 15.1.1, the build produces a warning. In practice, though, this cannot be hit because `exact` acts as a guard and that variable can only be set after `matchlen` is already initialized

Assign a default value to `matchlen` so that the warning is silenced.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 t/unit-tests/clar/clar.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/unit-tests/clar/clar.c b/t/unit-tests/clar/clar.c
index d54e455367..03a3aa8e87 100644
--- a/t/unit-tests/clar/clar.c
+++ b/t/unit-tests/clar/clar.c
@@ -350,7 +350,7 @@ static void
 clar_run_suite(const struct clar_suite *suite, const char *filter)
 {
 	const struct clar_func *test = suite->tests;
-	size_t i, matchlen;
+	size_t i, matchlen = 0;
 	struct clar_report *report;
 	int exact = 0;
 
-- 
2.50.1
Previous: Denton LiuNext: Patrick Steinhardt
Message 7 of 10 in “fix -Wmaybe-uninitialized with -Og”
  1. fix -Wmaybe-uninitialized with -OgDenton Liu, Aug 4, 2025
  2. Jeff KingAug 4, 2025
  3. Junio C HamanoAug 4, 2025
  4. Jeff KingAug 4, 2025
  5. 0/2 fix -Wmaybe-uninitialized with -OgDenton Liu, Aug 5, 2025
  6. 1/2 remote: bail early from set_head() if missing remote nameDenton Liu, Aug 5, 2025
  7. 2/2 t/unit-tests/clar: fix -Wmaybe-uninitialized with -OgDenton Liu, Aug 5, 2025
  8. Patrick SteinhardtAug 8, 2025
  9. Denton LiuAug 8, 2025
  10. Patrick SteinhardtAug 11, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.