Re: [PATCH v2 5/7] diff: simplify parsing of diff.colormovedws

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 1, 2025, 08:47 UTC
Message-ID: <aIx_InP6HRn7bO6k@pks.im>
In-Reply-To: <20250731224607.3942417-6-gitster@pobox.com>

On Thu, Jul 31, 2025 at 03:46:04PM -0700, Junio C Hamano wrote:

> The code to parse this configuration variable, whose value is a
> comma separated known tokens like "ignore-space-change" and

Should this read "comma-separated list of known tokens"?

Show 7 quoted lines

> "ignore-all-space", uses string_list_split() to split the value into
> pieces, and then places each piece of string in a strbuf to trim,
> before comparing the result with the list of known tokens.
> 
> Thanks to the previous steps, now string_list_split() can trim the
> resulting pieces before it places them in the string list.  Use it
> to simplify the code.

The change itself makes sense.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.