Re: [PATCH 1/5] string-list: report programming error with BUG

From

Eric Sunshine <sunshine@sunshineco.com>

Date

Jul 31, 2025, 19:33 UTC

Message-ID

<CAPig+cT9tBSo1od8iuCf+88rvDO9GEikKm38WLcXHemM-emhOw@mail.gmail.com>

In-Reply-To

<20250731063949.1601669-2-gitster@pobox.com>

On Thu, Jul 31, 2025 at 2:40 AM Junio C Hamano <gitster@pobox.com> wrote:

> Passing a string list that has .strdup_strings bit unset to
> string_list_split(), orone that has .strdup_strings bit set to
> string_list_split_in_place(), is a programmer error.  Do not use
> die() to abort the execution.  Use BUG() instead.

s/orone/or one/

> As a developer-facing message, the message string itself should
> be a lot more concise, but let's keep the original one for now.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>