Re: [GSoC][RFC PATCH 0/2] Add refs list subcommand

From: shejialuo <shejialuo@gmail.com>
Date: Jun 28, 2025, 08:05 UTC
Message-ID: <aF-iSSOmcplFjKQt@ArchLinux>
In-Reply-To: <xmqqh60183ku.fsf@gitster.g>

On Fri, Jun 27, 2025 at 11:03:13AM -0700, Junio C Hamano wrote:

Show 18 quoted lines

> Meet Soni <meetsoni3017@gmail.com> writes:
> 
> >   - Remove legacy or obscure options that are no longer needed.
> 
> Such as?
> 
> >   - Add improvements that wouldn't make sense to bolt onto legacy
> >     commands.
> 
> Such as?
> 
> While I agree that there may be cases that the above goals in
> general would bring us improvements, I think neither of these two
> applies to for-each-ref.  People are using for-each-ref to iterate
> over and enumerate refs already, and if you are to add some new
> features to "git refs list", they certainly will demand these new
> goodies to be added to for-each-ref as well.
>

If so, we would make "git refs list" to place "git for-each-ref" at all. However, in the current implementation, we indeed introduce duplicate code path if we decide to do above.

Thanks, Jialuo