Re: [GSoC][RFC PATCH v2 1/2] builtin/refs: add list subcommand
- From
Meet Soni <meetsoni3017@gmail.com>
- Date
- Jul 23, 2025, 05:01 UTC
- Message-ID
- <CAPhwyn0a6g1HCSKqN5oUxRCp9qfThqBDady1M9kDJikP1fc+3w@mail.gmail.com>
- In-Reply-To
- <CAPig+cQgeqz9bNQSFRvTmoyFgqAwEKSV=KpK18DSP7FA-4GDPw@mail.gmail.com>
On Thu, 17 Jul 2025 at 22:18, Eric Sunshine <sunshine@sunshineco.com> wrote:
> > On Thu, Jul 17, 2025 at 3:50 AM Meet Soni <meetsoni3017@gmail.com> wrote:
[snip]
Show 14 quoted lines
> > diff --git a/Documentation/refs-list-options.adoc b/Documentation/refs-list-options.adoc > > @@ -0,0 +1,80 @@ > > +// Shared options for for-each-ref and refs list > > +<pattern>...:: > > + If one or more patterns are given, only refs are shown that > > + match against at least one pattern, either using fnmatch(3) or > > + literally, in the latter case matching completely or from the > > + beginning up to a slash. > > Nit: We probably don't want the "// Shared options for..." comment. If > someone needs to know which commands share this documentation, a > suitable "grep" invocation will provide the same information but will > be correct at that point in time, whereas a comment like this one can > become stale over time.
Makes sense, I'll remove it in the next version.
Apologies for the delayed response, I was away last week. Thanks