git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] builtin/receive-pack: add option to skip connectivity check

From
Patrick Steinhardt <ps@pks.im>
Date
Jun 5, 2025, 11:00 UTC
Message-ID
<aEF4sxopIHndDpeb@pks.im>
In-Reply-To
<0c2cc369-f57d-e03c-88b4-2e3206953101@gmx.de>
On Thu, Jun 05, 2025 at 12:17:17PM +0200, Johannes Schindelin wrote:
Show 16 quoted lines
> Hi Patrick,
> On Tue, 3 Jun 2025, Patrick Steinhardt wrote:
> > On Mon, Jun 02, 2025 at 10:59:53AM -0500, Justin Tobler wrote:
> > > On 25/06/02 05:01PM, Johannes Schindelin wrote:
> > > Thanks Johannes for the report. I'm not quite sure yet what is going on
> > > here, but I'll dig into this a bit and see what I can figure out. :)
> > 
> > I've been banging my head against this issue for a bit today. A couple
> > of findings:
> > 
> >   - The issue is specific to Git for Windows, I could only reproduce it
> >     when working with aa550efd0bb (fixup??? survey: add command line
> >     opts to select references, 2025-05-08).
> 
> I can reproduce it consistently with Git's `master`, see e.g.
> https://github.com/git/git/actions/runs/15454602308/job/43504424816#step:6:627
Huh, interesting. Now that makes me wonder why I couldn't.
Show 22 quoted lines
> >   - When working on top of the above commit the bug is consistent. It
> >     doesn't only happen in GitHub, but also happens in GitLab CI [1].
> > 
> >   - That being said, I still can't reproduce it locally?! This one is
> >     quite puzzling to me. I have tried to get my environment as close as
> >     possible to the environment we have in the CI systems.
> 
> I, too, was unable to reproduce locally (probably because of the way the
> runners start the processes, without an initial Win32 Console and all). So
> I took to mxschmitt/action-tmate to debug on the runner itself. It is a
> bit tricky to do, as MSVC's debugger runs in a graphical IDE and gdb is
> unable to find the symbols.
> 
> >   - I have a fix, see the patch further down. But I don't understand
> >     that fix just yet.
> 
> I would like to propose an alternative:
> https://lore.kernel.org/git/pull.1932.git.1749118606047.gitgitgadget@gmail.com
> 
> The reason why I prefer that solution is that I suspect the extra script
> to make the conditions only less likely, but not impossible, for the bug
> to rear its ugly head.
Interesting find! I'll comment on that thread, thanks!
Patrick
Previous: Johannes SchindelinNext: Karthik Nayak
Message 24 of 25 in “builtin/receive-pack: introduce option to skip connectivity checks”
  1. 0/2 builtin/receive-pack: introduce option to skip connectivity checksJustin Tobler, May 7, 2025
  2. 1/2 t5412: test receive-pack connectivity checkJustin Tobler, May 7, 2025
  3. Patrick SteinhardtMay 7, 2025
  4. Justin ToblerMay 19, 2025
  5. 2/2 builtin/receive-pack: add option to skip connectivity checkJustin Tobler, May 7, 2025
  6. Patrick SteinhardtMay 7, 2025
  7. Junio C HamanoMay 7, 2025
  8. 0/2 builtin/receive-pack: introduce option to skip connectivity checksJustin Tobler, May 20, 2025
  9. 1/2 t5410: test receive-pack connectivity checkJustin Tobler, May 20, 2025
  10. Karthik NayakMay 20, 2025
  11. 2/2 builtin/receive-pack: add option to skip connectivity checkJustin Tobler, May 20, 2025
  12. Patrick SteinhardtMay 20, 2025
  13. Justin ToblerMay 20, 2025
  14. Karthik NayakMay 20, 2025
  15. 0/2 builtin/receive-pack: introduce option to skip connectivity checksJustin Tobler, May 20, 2025
  16. 1/2 t5410: test receive-pack connectivity checkJustin Tobler, May 20, 2025
  17. 2/2 builtin/receive-pack: add option to skip connectivity checkJustin Tobler, May 20, 2025
  18. Johannes SchindelinJun 2, 2025
  19. Justin ToblerJun 2, 2025
  20. Johannes SchindelinJun 2, 2025
  21. Junio C HamanoJun 2, 2025
  22. Patrick SteinhardtJun 3, 2025
  23. Johannes SchindelinJun 5, 2025
  24. Patrick SteinhardtJun 5, 2025
  25. Karthik NayakMay 22, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.