Re: [PATCH 2/2] meson: prefer POSIX-specified shell path

From: Patrick Steinhardt <ps@pks.im>
Date: Apr 25, 2025, 05:21 UTC
Message-ID: <aAsb2SEbxatCw9Zs@pks.im>
In-Reply-To: <m2egcx4i2nezlwlyioofnz4srjgbyhb4dkyrpi5crnt5uwuvy3@a7tbji5lrnvn>

On Thu, Apr 24, 2025 at 03:18:29PM -0500, Justin Tobler wrote:

Show 13 quoted lines

> On 25/04/24 03:38PM, Patrick Steinhardt wrote:
> > diff --git a/meson.build b/meson.build
> > index 8f04534c7ff..1db768380bd 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -236,7 +236,7 @@ sed = find_program('sed', dirs: program_path, native: true)
> >  shell = find_program('sh', dirs: program_path, native: true)
> >  tar = find_program('tar', dirs: program_path, native: true)
> >  
> > -target_shell = find_program('sh', dirs: program_path, native: false)
> > +target_shell = find_program('sh', dirs: program_path + [ '/bin' ], native: false)
> 
> It might be nice to leave a comment explaining the ordering intent.

Will do.

Patrick