Re: [PATCH 1/2] meson: report detected runtime executable paths

From: Eli Schwartz <eschwartz@gentoo.org>
Date: Apr 25, 2025, 00:45 UTC
Message-ID: <43e86c8f-904b-4572-b84d-009c203fda11@gentoo.org>
In-Reply-To: <20250424-pks-meson-posix-shell-v1-1-45e06ee4b6ad@pks.im>

On 4/24/25 9:38 AM, Patrick Steinhardt wrote:

Show 28 quoted lines

> Git needs to know about a couple of executable paths to pick at runtime.
> This includes the system shell, but may also optionally include the Perl
> and Python interpreters. Meson detects the location of these paths
> automatically via `find_program()`, which does a lookup via the `PATH`
> environment variable. As such, it may not be immediately obvious to the
> developer which paths have been autodetected.
> 
> Improve this by exposing runtime executable paths at setup time.
> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  meson.build | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index c47cb79af08..8f04534c7ff 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2080,3 +2080,9 @@ summary({
>    'sha256': sha256_backend,
>    'zlib': zlib_backend,
>  }, section: 'Backends')
> +
> +summary({
> +  'perl': target_perl.found() ? target_perl.full_path() : 'none',
> +  'python': target_python.found() ? target_python.full_path() : 'none',
> +  'shell': target_shell.full_path(),
> +}, section: 'Runtime executable paths')

summary({
  'perl': target_perl,
  'python': target_python,
  'shell': target_shell,
}, section: 'Runtime executable paths')

No need to check if they are found. Meson will print the full_path() already, if it is found, and if it is not found, it will print "NO" in its standard color code (red) for things-that-are-missing.

-- 
Eli Schwartz