Re: [PATCH v2 0/6] meson: miscellaneous system detection fixes

From: Patrick Steinhardt <ps@pks.im>
Date: Apr 25, 2025, 04:39 UTC
Message-ID: <aAsSDA5y_Dur9PGj@pks.im>
In-Reply-To: <20250425002017.246985-1-eschwartz@gentoo.org>

On Thu, Apr 24, 2025 at 08:13:29PM -0400, Eli Schwartz wrote:

> Principally motivated to handle an issue where these were failing to
> detect the system properly, on Solaris.

I was expecting to also see my comments addressed around the one style issue as well as the comment regarding `fs.exists()` being a bit too magical (both mentioned in [1]). This is the only remaining item that I'd like to see addressed, and other than that this series looks good to me.

Patrick

[1]: <aAdFysi-n_5Aa4Au@pks.im>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.