Re: [PATCH v2 0/6] meson: miscellaneous system detection fixes

From: Eli Schwartz <eschwartz@gentoo.org>
Date: Apr 25, 2025, 05:27 UTC
Message-ID: <7d7c22c9-953f-43b4-8976-9303effd63ea@gentoo.org>
In-Reply-To: <aAsSDA5y_Dur9PGj@pks.im>

On 4/25/25 12:39 AM, Patrick Steinhardt wrote:

Show 9 quoted lines

> On Thu, Apr 24, 2025 at 08:13:29PM -0400, Eli Schwartz wrote:
>> Principally motivated to handle an issue where these were failing to
>> detect the system properly, on Solaris.
> 
> I was expecting to also see my comments addressed around the one style
> issue as well as the comment regarding `fs.exists()` being a bit too
> magical (both mentioned in [1]). This is the only remaining item that
> I'd like to see addressed, and other than that this series looks good to
> me.

I overlooked the style comment, will fix.

Regarding the fs.exists I was worried that it would be repetitive and unwieldy but I think I found a good solution, as a bonus I can now handle strtoumax.

-- 
Eli Schwartz