git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] send-email: --smtp-ssl-cert-path takes an argument

From
Thomas Rast <tr@thomasrast.ch>
Date
Dec 1, 2013, 22:48 UTC
Message-ID
<a8acc2b499f1635be6a7f7414aca8cfd75a7c828.1385938050.git.tr@thomasrast.ch>
In-Reply-To
<3bb0c80c70e1c40236034552bec037cb0c26167c.1385938050.git.tr@thomasrast.ch>

35035bb (send-email: be explicit with SSL certificate verification, 2013-07-18) forgot to specify that --smtp-ssl-cert-path takes a string argument. This means that the option could not actually be used as intended. Presumably noone noticed because it's much easier to set it through configs anyway.

Add the required "=s".
Signed-off-by: Thomas Rast <tr@thomasrast.ch>
---
 git-send-email.perl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index f7468b6..9f31c68 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -291,7 +291,7 @@ sub signal_handler {
 		    "smtp-pass:s" => \$smtp_authpass,
 		    "smtp-ssl" => sub { $smtp_encryption = 'ssl' },
 		    "smtp-encryption=s" => \$smtp_encryption,
-		    "smtp-ssl-cert-path" => \$smtp_ssl_cert_path,
+		    "smtp-ssl-cert-path=s" => \$smtp_ssl_cert_path,
 		    "smtp-debug:i" => \$debug_net_smtp,
 		    "smtp-domain:s" => \$smtp_domain,
 		    "identity=s" => \$identity,
-- 
1.8.5.rc3.5.g2a1fe2f
Previous: Thomas RastNext: Thomas Rast
Message 2 of 5 in “send-email: pass Debug to Net::SMTP::SSL::new”
  1. 1/3 send-email: pass Debug to Net::SMTP::SSL::newThomas Rast, Dec 1, 2013
  2. 2/3 send-email: --smtp-ssl-cert-path takes an argumentThomas Rast, Dec 1, 2013
  3. 3/3 send-email: set SSL options through IO::Socket::SSL::set_client_defaultsThomas Rast, Dec 1, 2013
  4. Ramkumar RamachandraDec 2, 2013
  5. Thomas RastDec 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.