git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] send-email: pass Debug to Net::SMTP::SSL::new

From
Thomas Rast <tr@thomasrast.ch>
Date
Dec 1, 2013, 22:48 UTC
Message-ID
<3bb0c80c70e1c40236034552bec037cb0c26167c.1385938050.git.tr@thomasrast.ch>

We forgot to pass the Debug option through to Net::SMTP::SSL->new -- which is the same as Net::SMTP->new. This meant that with security set to SSL, we would never enable debug output.

Pass through the flag.
Signed-off-by: Thomas Rast <tr@thomasrast.ch>
---
 git-send-email.perl | 1 +
 1 file changed, 1 insertion(+)
diff --git a/git-send-email.perl b/git-send-email.perl
index 3782c3b..f7468b6 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1217,6 +1217,7 @@ sub send_message {
 			$smtp ||= Net::SMTP::SSL->new($smtp_server,
 						      Hello => $smtp_domain,
 						      Port => $smtp_server_port,
+						      Debug => $debug_net_smtp,
 						      ssl_verify_params());
 		}
 		else {
-- 
1.8.5.rc3.5.g2a1fe2f
Next: Thomas Rast
Message 1 of 5 in “send-email: pass Debug to Net::SMTP::SSL::new”
  1. 1/3 send-email: pass Debug to Net::SMTP::SSL::newThomas Rast, Dec 1, 2013
  2. 2/3 send-email: --smtp-ssl-cert-path takes an argumentThomas Rast, Dec 1, 2013
  3. 3/3 send-email: set SSL options through IO::Socket::SSL::set_client_defaultsThomas Rast, Dec 1, 2013
  4. Ramkumar RamachandraDec 2, 2013
  5. Thomas RastDec 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.