Re: [PATCH] Trivial fix: Make all the builtin usage strings to use the same pattern.
- From
Thiago Farina <tfransosi@gmail.com>
- Date
- Sep 20, 2009, 14:51 UTC
- Message-ID
- <a4c8a6d00909200751r87fdf83oe92e5a2076b1b527@mail.gmail.com>
- In-Reply-To
- <20090920143526.GA22295@dualtron.vpn.rwth-aachen.de>
On Sun, Sep 20, 2009 at 11:35 AM, Johannes Gilger <heipei@hackvalue.de> wrote:
Show 11 quoted lines
> On 20/09/09 09:17, Thiago Farina wrote:
>> They follow the pattern of file name:
>> File name pattern: builtin-command-name.c
>> Usage string pattern: builtin_command_name_usage
>> [...]
>> -static char const * const archive_usage[] = {
>> +static const char * const archive_usage[] = {
>> "git archive [options] <tree-ish> [path...]",
>> "git archive --list",
>> "git archive --remote <repo> [--exec <cmd>] [options] <tree-ish> [path...]",
> Looks like you missed a spot ;)The change here is about 'char const *' to 'const char *', to match with the definition in api-parse-options.txt. :) Is there a reason for archive do not has a builtin- in it file name?