Re: [PATCH] Update the usage bundle string.

From: Thiago Farina <tfransosi@gmail.com>
Date: Sep 17, 2009, 15:56 UTC
Message-ID: <a4c8a6d00909170856t69695a33u86fbc7bc1d9a008@mail.gmail.com>
In-Reply-To: <4AB1D364.1080701@viscovery.net>

On Thu, Sep 17, 2009 at 3:12 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:

Show 6 quoted lines

> Thiago Farina schrieb:
>> @@ -11,6 +11,12 @@
>>
>>  static const char *bundle_usage="git bundle (create <bundle> <git rev-list args> | verify <bundle> | list-heads <bundle> [refname]... | unbundle <bundle> [refname]... )";
>
> Is this variable still used? Shouldn't it be removed?

Yeah it should be removed, I did this in the third email that I sent. To send another revision of the patch I'm doing this: $ git commit <filename> --amend $ git format-patch -1 --subject-prefix "Patch vN" But I'm not sure if this is the correct away to send another set of changes of the same patch. Is right?

Show 17 quoted lines

>
>> +static const char builtin_bundle_usage[] = "\
>> +  git bundle create <file> <git-rev-list args>\n\
>> +  git bundle verify <file>\n\
>> +  git bundle list-heads <file> [refname...]\n\
>> +  git bundle unbundle <file> [refname...]";
>
> You indent the usage text. Do other commands do that, too? If you resend,
> it may be worth using this style:
>
> static const char builtin_bundle_usage[] =
>        "git bundle create <file> <git-rev-list args>\n"
>        "git bundle verify <file>\n"
> ...
>
> i.e. not to use backslash-at-eol.
>

Sure, I will update it to use this style. There is another usage string that uses backslash-at-eol, it is in builtin-pack-objecs.c . Should I update this string too?

Show 6 quoted lines

>> -     if (argc < 3)
>> -             usage(bundle_usage);
>> +  if (argc < 3)
>> +             usage(builtin_bundle_usage);
>
> This re-indentation is an accident, isn't it?

Was an accident, sorry about that. I configured my editor to use 2 spaces per indent, tab size 2 and expand tabs to spaces. Git uses 4 spaces per indent and tab size 4?

>
> -- Hannes
>
>